Wire up startViewTransitionReadyFinished in Fabric#36246
Open
zeyap wants to merge 2 commits intofacebook:mainfrom
Open
Wire up startViewTransitionReadyFinished in Fabric#36246zeyap wants to merge 2 commits intofacebook:mainfrom
zeyap wants to merge 2 commits intofacebook:mainfrom
Conversation
Import startViewTransitionReadyFinished from nativeFabricUIManager and call it when the view transition ready promise resolves.
|
Comparing: 705268d...2e2f432 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
The property was destructured in ReactFiberConfigFabricWithViewTransition but missing from the Flow type declaration, causing a prop-missing error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startViewTransitionReadyFinishedfromnativeFabricUIManagerinReactFiberConfigFabricWithViewTransitionfabricStartViewTransitionReadyFinished()when the view transitionreadypromise resolvesThis is not a config function, but it's helpful to have it notify fabric ViewTransition runtime when ready callback is done. Right now we're testing animation kicked off from view transition event handlers, this is signal to know when animations that belong to a transition have all started.
Test plan