Remove setTimeout polyfill from JS shell code. NFC#26727
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 21, 2026
Merged
Remove setTimeout polyfill from JS shell code. NFC#26727sbc100 merged 1 commit intoemscripten-core:mainfrom
setTimeout polyfill from JS shell code. NFC#26727sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
All the JS shells, including spidermonkey, seem to support setTimeout natively these days.
sbc100
force-pushed
the
setTimeout_polyfill
branch
from
d417256 to
8306f98
Compare
lygstate
reviewed
Apr 19, 2026
|
|
||
| globalThis.clearTimeout ??= (id) => {}; | ||
|
|
||
| // spidermonkey lacks setTimeout but we use it above in readAsync. |
There was a problem hiding this comment.
If setTimeout removed, then I think clearTimeout also need removed
Collaborator
Author
There was a problem hiding this comment.
Actually not. While all the of the JS shells support setTimeout, none of them support clearTimeout
kripken
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the JS shells, including spidermonkey, seem to support setTimeout natively these days.