Skip to content

SourceList: use key controller #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremypw merged 3 commits into from
Apr 21, 2026
+15 −11
Merged

SourceList: use key controller #1710

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3434d2d
SourceList: use key controller
danirabbit Apr 15, 2026
1900f5c
Fix warning
danirabbit Apr 15, 2026
d83208d
Merge branch 'master' into danirabbit/sourcelist-keycontroller
jeremypw Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/Widgets/SourceList/SourceList.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1571,6 +1571,7 @@ public class SourceList : Gtk.ScrolledWindow {

private Gtk.Entry? editable_entry;
private Gtk.CellRendererText text_cell;
private Gtk.EventControllerKey key_controller;
private CellRendererIcon icon_cell;
private CellRendererIcon activatable_cell;
private CellRendererBadge badge_cell;
Expand Down Expand Up @@ -1725,6 +1726,9 @@ public class SourceList : Gtk.ScrolledWindow {

query_tooltip.connect_after (on_query_tooltip);
has_tooltip = true;

key_controller = new Gtk.EventControllerKey (this);
key_controller.key_released.connect (on_key_released);
}

~Tree () {
Expand Down Expand Up @@ -2239,19 +2243,19 @@ public class SourceList : Gtk.ScrolledWindow {
}
}

public override bool key_release_event (Gdk.EventKey event) {
if (selected_item != null) {
switch (event.keyval) {
case Gdk.Key.F2:
var modifiers = Gtk.accelerator_get_default_mod_mask ();
// try to start editing selected item
if ((event.state & modifiers) == 0 && selected_item.editable)
start_editing_item (selected_item);
break;
}
private void on_key_released (uint keyval, uint keycode, Gdk.ModifierType state) {
if (selected_item == null) {
return;
}

return base.key_release_event (event);
switch (keyval) {
case Gdk.Key.F2:
var modifiers = Gtk.accelerator_get_default_mod_mask ();
// try to start editing selected item
if ((state & modifiers) == 0 && selected_item.editable)
start_editing_item (selected_item);
break;
}
}

public override bool button_release_event (Gdk.EventButton event) {
Expand Down