Conversation
Signed-off-by: joey <zchengjoey@gmail.com> (cherry picked from commit 01e1125)
chengjoey
requested review from
ValentaTomas,
jakubno and
mishushakov
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01798ffa5a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| reqCtx := ctx | ||
| var cancel context.CancelFunc | ||
| if timeout > 0 { | ||
| reqCtx, cancel = context.WithTimeout(ctx, timeout+s.connection.RequestTimeout) |
There was a problem hiding this comment.
RunCodeOpts exposes a per-call RequestTimeout, but RunCode always derives its deadline from s.connection.RequestTimeout here. That means callers cannot override the HTTP timeout for an individual execution, and cases like Timeout = -1 can end up with no request deadline at all even when RequestTimeout is set in opts. This breaks the documented timeout contract and can cause unexpected hangs or premature timeouts depending on global config.
Useful? React with 👍 / 👎.
| APIKey: opts.APIKey, | ||
| AccessToken: opts.AccessToken, | ||
| Domain: opts.Domain, | ||
| Debug: opts.Debug, | ||
| RequestTimeout: opts.RequestTimeout, |
There was a problem hiding this comment.
The sandbox connection is initialized from SandboxOpts without any way to populate TrafficAccessToken. Since direct Jupyter/context requests only send E2B-Traffic-Access-Token when connection.TrafficAccessToken is set, callers cannot authenticate those requests in environments that require the traffic token (resulting in 403s despite valid API credentials).
Useful? React with 👍 / 👎.
1 participant
add golang sdk like python/js