Skip to content

Allow small, medium and large engines#58

Open
ivpusic wants to merge 1 commit intomainfrom
small_engine
Open

Allow small, medium and large engines#58
ivpusic wants to merge 1 commit intomainfrom
small_engine

Conversation

@ivpusic
Copy link
Copy Markdown
Member

@ivpusic ivpusic commented Apr 28, 2026

Updates dune query run and dune query run-sql to advertise --performance tiers as small|medium|large (including README and flag help text), replacing the previously documented free tier.

@ivpusic ivpusic marked this pull request as ready for review April 29, 2026 10:20
@ivpusic ivpusic requested review from charisra and norbertdurcansk and removed request for norbertdurcansk April 29, 2026 10:20
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 29, 2026

PR Summary

Low Risk
Primarily documentation/flag validation updates with added tests; behavior change is limited to accepting small and keeping free as a tolerated legacy value.

Overview
The CLI now advertises --performance tiers as small|medium|large (README and query run/query run-sql flag help), replacing the previously documented free tier.

Internally, parsePerformance is updated to validate small|medium|large while still accepting and forwarding legacy free; tests are adjusted to expect small and new coverage pins the free compatibility behavior.

Reviewed by Cursor Bugbot for commit 0373515. Configure here.

@charisra
Copy link
Copy Markdown
Contributor

bugbot run

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 0373515. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants