Issue #423: Upgraded mezzio-oauth2 to v3.0.1#424
Open
SergiuBota1 wants to merge 4 commits into7.0from
Open
Conversation
Signed-off-by: bota <Bota@dotkernel.com>
Qodana for JSIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
alexmerlin
requested changes
Apr 30, 2026
Member
alexmerlin
left a comment
alexmerlin
left a comment
There was a problem hiding this comment.
Although it's beyond the scope of this feature, let's also sync these files:
Core\Admin\Entity\AdminLoginCore\App\Service\IpService
Signed-off-by: bota <Bota@dotkernel.com>
Signed-off-by: bota <Bota@dotkernel.com>
alexmerlin
requested changes
Apr 30, 2026
Member
alexmerlin
left a comment
alexmerlin
left a comment
There was a problem hiding this comment.
Core\App\Service\IpService still needs some cosmetic modifications - just copy the file contents over from API, then they should be identical.
Signed-off-by: bota <Bota@dotkernel.com>
Member
Author
|
Synchronized the classes, but had to patch some PHPStan issues in Admin. Wouldn't it be better to fix the method signature in the source class (both Admin and API) instead of patching where is called? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.