Bump Eclipse JDT from 4.35 to 4.40#2902
Draft
jhthompson wants to merge 4 commits intodiffplug:mainfrom
Draft
Conversation
Author
|
Actually this might not be ready to merge. I didn't realize you could specify a version override manually, I think 4.38 and onwards are broken in Spotless: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I noticed that VSCode's "Language support for Java" formatter was formatting some things differently than Spotless (when pointing to the same eclipse formatter XML file. Spotless is at 4.35, looks like VSCode embeds:
~./vscode-server/extensions/redhat.java-1.54.0/server/plugins/org.eclipse.jdt.core_3.46.0.v20260409-1507.jarJDT 3.46.0 (which I think corresponds to 4.39?).Fix
Bump the Spotless Eclipse JDT version.
Refs