Update product names: Workflows→Jobs, Delta Live Tables→Spark Declarative Pipelines#4967
Merged
lennartkats-db merged 19 commits intomainfrom Apr 17, 2026
Merged
Update product names: Workflows→Jobs, Delta Live Tables→Spark Declarative Pipelines#4967lennartkats-db merged 19 commits intomainfrom
lennartkats-db merged 19 commits intomainfrom
Conversation
…tive Pipelines Update all non-generated references to retired product names: - "Databricks Workflows" / "Workflows" → "Databricks Jobs" / "Jobs" - "Delta Live Tables" → "Spark Declarative Pipelines" - "DLT" → "SDP" (in comments/internal code) - Template parameter `include_dlt` → `include_sdp` - Template file `dlt_pipeline.ipynb` → `sdp_pipeline.ipynb` Generated files (schema JSON, docsgen, acceptance test outputs, Python models) are not updated here — regenerate with `make schema`, `make docs`, `make test-update`, `make test-update-templates`, `make -C python codegen` after the upstream proto changes land. Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
With include_pipeline properly wired (was silently ignored as include_dlt), PIPELINE=no now excludes the pipeline resource. With only a job resource, dynamic_version causes 1 change and 0 unchanged, which is correct behavior. Co-authored-by: Isaac
The template renamed include_dlt to include_pipeline in a prior PR, but the combinations test intentionally still passes include_dlt (which gets silently ignored, defaulting to yes). Renaming to include_pipeline makes PIPELINE=no actually exclude pipelines, causing divergent output across variants which the combinations framework doesn't support. Co-authored-by: Isaac
The output was corrupted when running tests locally without terraform, replacing the successful deployment output with terraform init errors. Restores correct output from main and applies DLT→SDP string change. Co-authored-by: Isaac
lennartkats-db
changed the title
pietern
approved these changes
Apr 16, 2026
simonfaltum
reviewed
Apr 16, 2026
Member
simonfaltum
left a comment
simonfaltum
left a comment
There was a problem hiding this comment.
Review swarm: Isaac + Cursor (1 round, Cursor timed out)
0 Critical | 1 Major (Gap) | 1 Nit | 1 Suggestion
The rename changes look correct across the board. A few things worth addressing before merge, the main one being that jsonschema.json appears to be manually edited rather than regenerated from the source annotations. There are also a couple of downstream generated files (jsonschema_for_docs.json, docsgen/output/reference.md, docsgen/output/resources.md) that still contain the old product names.
See inline comments for specifics.
…stroy.go Address review feedback: drop "SDP" from comment since the variable name already says "pipeline", and rename the missed dltActions variable. Co-authored-by: Isaac
Address review feedback: edit annotations source files and regenerate via make schema/schema-for-docs/docs instead of manually editing generated files. Also picks up other schema changes from the codebase. Co-authored-by: Isaac
Collaborator
juliacrawf-db
left a comment
juliacrawf-db
left a comment
There was a problem hiding this comment.
Similar to the comments I made on the DABs rename PR, from Dylan Vance:
- In general, it's safer to say "Lakeflow Spark Declarative Pipelines" than just "Spark Declarative Pipelines", to avoid confusion.
- The name of the feature is "Spark Declarative Pipelines". The resource that it creates is a "pipeline". Do not use "Spark Declarative Pipeline" or "Lakeflow Spark Declarative Pipeline", as this isn't a thing.
It's very similar to DABs creating a bundle.
- Use "Jobs & Pipelines" for UI navigation references in template READMEs - Remove singular "Spark Declarative Pipeline" — feature name is always plural - Use just "pipeline" when referring to the resource, not the product - Regenerate template outputs and help text Co-authored-by: Isaac
…nes](...)" Co-authored-by: Isaac
Co-authored-by: Julia Crawford (Databricks) <julia.crawford@databricks.com>
Per Julia's review: prefer "Lakeflow Spark Declarative Pipelines" over bare "Spark Declarative Pipelines" to avoid confusion. Co-authored-by: Isaac
- Change "stub (sample) pipeline" to "stub (sample) ETL pipeline" - Regenerate acceptance tests for Lakeflow prefix in run_as warning Co-authored-by: Isaac
This template is hidden/unlisted — renaming properties would break existing users without benefit. Co-authored-by: Isaac
…ct name - run_as warning: "pipelines in your DABs project" instead of product name - Pipeline resource description: "create pipelines" instead of product name - Regenerate schema, docs, and acceptance test outputs Co-authored-by: Isaac
# Conflicts: # bundle/schema/jsonschema_for_docs.json
Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
include_dlt→include_sdpand filedlt_pipeline.ipynb→sdp_pipeline.ipynbin experimental-jobs-as-code template