Skip to content

chore: cleaner argocd plan diffs#1001

Merged
adityachoudhari26 merged 1 commit intomainfrom
cleaner-argo-diffs
Apr 15, 2026
Merged

chore: cleaner argocd plan diffs#1001
adityachoudhari26 merged 1 commit intomainfrom
cleaner-argo-diffs

Conversation

@adityachoudhari26
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 15, 2026 23:25
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

Warning

Rate limit exceeded

@adityachoudhari26 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 45 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 1 minutes and 45 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e4f1beba-372f-4653-90e2-1f118caf65da

📥 Commits

Reviewing files that changed from the base of the PR and between 17b00f1 and 0aa495e.

📒 Files selected for processing (2)
  • apps/workspace-engine/pkg/jobagents/argo/argoapp_test.go
  • apps/workspace-engine/pkg/jobagents/argo/argocd_plan.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cleaner-argo-diffs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves readability of ArgoCD plan diffs by converting ArgoCD-returned JSON manifests into YAML before generating the Current/Proposed diff payloads.

Changes:

  • Convert manifest strings from JSON → YAML prior to Current/Proposed concatenation in the ArgoCD planner.
  • Update plan unit test assertions to reflect YAML-formatted output.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/workspace-engine/pkg/jobagents/argo/argocd_plan.go Converts manifest output to YAML to produce cleaner, more human-friendly plan diffs.
apps/workspace-engine/pkg/jobagents/argo/argoapp_test.go Adjusts expectations to validate YAML content rather than raw JSON equality.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adityachoudhari26 adityachoudhari26 merged commit e0fee64 into main Apr 15, 2026
13 checks passed
@adityachoudhari26 adityachoudhari26 deleted the cleaner-argo-diffs branch April 15, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants