Skip to content

chore: pass baseurl to workspace engine #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityachoudhari26 merged 5 commits into from
Apr 17, 2026
Merged

chore: pass baseurl to workspace engine #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c9738c9
chore: pass baseurl to workspace engine
adityachoudhari26 Apr 17, 2026
611de69
bump chart version
adityachoudhari26 Apr 17, 2026
80903e4
fix lint test
adityachoudhari26 Apr 17, 2026
50b602c
ifx
adityachoudhari26 Apr 17, 2026
944f84b
fix
adityachoudhari26 Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/lint-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ jobs:
- name: Set up chart-testing
uses: helm/chart-testing-action@v2.6.1

- name: Install wandb chart repository
run: helm repo add wandb https://charts.wandb.ai

- name: Run chart-testing (list-changed)
id: list-changed
run: |
Expand Down
2 changes: 1 addition & 1 deletion charts/ctrlplane/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: ctrlplane
description: Ctrlplane Helm chart for Kubernetes
type: application
version: 1.1.0
version: 1.1.1
appVersion: 1.0.0

maintainers:
Expand Down
6 changes: 4 additions & 2 deletions charts/ctrlplane/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ global:

# Secret management (propagated to subcharts via global).
# When empty, secrets are auto-generated by the chart.
# To reference externally managed secrets (e.g. ExternalSecrets), use valueFrom.
# To reference externally managed secrets (e.g. ExternalSecrets),
# use valueFrom.
secrets:
authSecret: ""
# authSecret:
Expand Down Expand Up @@ -123,7 +124,7 @@ ingress:
annotations: {}
tls:
enabled: false
secretName: "" # defaults to <fullname>-tls when empty
secretName: "" # defaults to <fullname>-tls when empty

otel:
install: true
Expand Down Expand Up @@ -241,6 +242,7 @@ workspace-engine:
name: pprof

env:
BASE_URL: "{{ .Values.global.fqdn }}"
GITHUB_URL: "{{ .Values.global.integrations.github.url }}"

envTpls:
Expand Down
Loading