[codegen] extract global variable generation from llvm-generator#755
Merged
[codegen] extract global variable generation from llvm-generator#755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
llvm-generator.tscontained ~1300 lines of global variable classification and generation logic, contributing to its 4893-line god file status.After
No user-facing change. Internal refactor only. Global variable logic now lives in
src/codegen/infrastructure/global-variable-generator.ts(1412 lines), reducingllvm-generator.tsto 3623 lines.Description
Extracts 9 methods from LLVMGenerator into free functions taking a
GlobalVarContextinterface:prePopulateFromSema— seeds symbol table from sema resultsgenerateGlobalVariableDeclarations— main entry point for global var IRtryHandleGlobalCallReturn,tryHandleGlobalJSONParse,tryHandleGlobalDeclaredType,tryHandleGlobalExpressionType,classifyGlobalCatchAll,tryGetConstLiteralValue,handleUninitializedGlobalVar— internal helpersUses flat interface methods (no chained calls like
ctx.symbolTable.define()) for native compiler compatibility.Part of #727.