Skip to content

[type-system] explicit dispatch in fieldToLlvmType, fail-loud on empty interface types #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cs01 merged 3 commits into from
Apr 27, 2026
Merged

[type-system] explicit dispatch in fieldToLlvmType, fail-loud on empty interface types #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38f45f7
re-trigger ci
cs01 Apr 26, 2026
c9ad9ef
re-trigger ci
cs01 Apr 26, 2026
73ebc43
[type-system] add explicit dispatch to fieldToLlvmType, fail-loud on …
cs01 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/codegen/types/interface-struct-generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export class InterfaceStructGenerator {

private tsTypeToLlvmForField(fieldName: string, tsType: string): string {
if (tsType === null || tsType === undefined || tsType === "") {
return "i8*";
throw new Error(`tsTypeToLlvmForField: empty type for field '${fieldName}'`);
}
if (this.interfaceStructs.has(tsType)) {
return "i8*";
Expand All @@ -171,7 +171,7 @@ export class InterfaceStructGenerator {

private tsTypeToLlvm(tsType: string): string {
if (tsType === null || tsType === undefined || tsType === "") {
return "i8*";
throw new Error("tsTypeToLlvm: empty type");
}
if (this.interfaceStructs.has(tsType)) {
return "i8*";
Expand Down
18 changes: 18 additions & 0 deletions src/codegen/types/objects/class.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,15 @@ export class ClassGenerator {
if (this.isEnumType(ts)) {
return "double";
}
if (ts === "string" || ts === "void" || ts === "any" || ts === "unknown" || ts === "object")
return "i8*";
if (ts === "null" || ts === "undefined" || ts === "never") return "i8*";
if (ts.indexOf(" | ") !== -1) return "i8*";
if (ts.startsWith("{")) return "i8*";
if (ts.startsWith('"')) return "i8*";
if (ts.indexOf("=>") !== -1 || ts.startsWith("(")) return "i8*";
if (ts === "i8*" || ts === "i1") return ts;
if (ts.startsWith("%")) return ts;
return "i8*";
}
if (ft === "double") return "double";
Expand Down Expand Up @@ -170,6 +179,15 @@ export class ClassGenerator {
if (this.isEnumType(ts)) {
return "double";
}
if (ts === "string" || ts === "void" || ts === "any" || ts === "unknown" || ts === "object")
return "i8*";
if (ts === "null" || ts === "undefined" || ts === "never") return "i8*";
if (ts.indexOf(" | ") !== -1) return "i8*";
if (ts.startsWith("{")) return "i8*";
if (ts.startsWith('"')) return "i8*";
if (ts.indexOf("=>") !== -1 || ts.startsWith("(")) return "i8*";
if (ts === "i8*" || ts === "i1") return ts;
if (ts.startsWith("%")) return ts;
return "i8*";
}
}
Expand Down
Loading