[simd.{syn,math}] Rename parameters of new overloads of various special maths functions:#8993
Open
tkoeppe wants to merge 1 commit intocplusplus:mainfrom
Open
[simd.{syn,math}] Rename parameters of new overloads of various special maths functions:#8993tkoeppe wants to merge 1 commit intocplusplus:mainfrom
tkoeppe wants to merge 1 commit intocplusplus:mainfrom
Conversation
…al maths functions:
* For comp_ellint_3: from "x, y" to "k, nu"
* For cyl_bessel_{i,j,k}: from "x, y" to "nu, x"
* For cyl_neumann: from "x, y" to "nu, x"
* For ellint_{1,2}: from "x, y" to "k, phi"
* For ellint_{1,2}: from "x, y, z" to "k, nu, phi"
The paper P3844R4 (LWG Motion 4) added those overloads with parameters
named differently from the names of the existing overloads, but the
latter names seem more appropriate.
Addresses editorial review committee feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The paper P3844R4 (LWG Motion 4) added those overloads with parameters named differently from the names of the existing overloads, but the latter names seem more appropriate.
Addresses editorial review committee feedback.