Add website-targeted JavaScript Skin Designer integration#4758
Open
liannacasper wants to merge 10 commits intomasterfrom
Open
Add website-targeted JavaScript Skin Designer integration#4758liannacasper wants to merge 10 commits intomasterfrom
liannacasper wants to merge 10 commits intomasterfrom
Conversation
Contributor
Cloudflare Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ShouldExecuteimplementation for the JavaScript port that returnstrueand posts acn1-skindesigner-ui-readymessage to the parent page to support embedded hosting (file:scripts/skindesigner/javascript/src/main/javascript/com_codename1_tools_skindesigner_ShouldExecute.js)./skindesigner/with loading UI and dark-mode sync (files:docs/website/content/skindesigner.mdanddocs/website/layouts/_default/skindesigner.html).docs/website/hugo.toml.scripts/website/build.shto optionally build and extract the Skin Designer JavaScript bundle intodocs/website/static/skindesigner-appusingWEBSITE_INCLUDE_SKINDESIGNER, following the same pattern used for Playground/Initializr.Testing
bash -n scripts/website/build.shwhich reported no syntax errors in the modified build script.sh ./mvnw -q -pl javascript -am -DskipTests -Dcodename1.platform=javascript packageinscripts/skindesigner, but the build failed in this environment due to missing Java 8 (JAVA_HOMEpath not present) and network/maven wrapper download errors (java.net.SocketException: Network is unreachable).Codex Task