feat: Add `incrementAll()` and `decrementAll()` methods to BaseBuilder and other driver specific builders by patel-vansh · Pull Request #10140 · codeigniter4/CodeIgniter4

patel-vansh · 2026-04-25T07:04:45Z

Description
This PR adds two new functions in BaseBuilder.php — incrementAll() and decrementAll(). These two functions enable devs to increment/decrement multiple rows at once atomically.

Also, the increment() and decrement() methods now internally call incrementAll() and decrementAll() respectively to prevent duplicating the logic.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

…ns as input Co-authored-by: Copilot <copilot@github.com>

paulbalandan

Have you considered adding a separate incrementAll (or other wording) that will take care of the array, so to minimize the BC break?

PS. The random test failure seems legitimate. I'll deal with that later.

michalsn · 2026-04-25T07:50:14Z

I also think that incrementMany() or incrementAll() would probably work better.

patel-vansh · 2026-04-25T09:09:49Z

Yeah, that would avoid BC. I guess incrementAll would be the new method.

Maybe the current increment method calls incrementAll internally? So, there's no duplication of any logic.
@paulbalandan and @michalsn

michalsn · 2026-04-25T09:24:09Z

Maybe the current increment method calls incrementAll internally? So, there's no duplication of any logic.

I see why not.

Co-authored-by: Copilot <copilot@github.com>

patel-vansh · 2026-04-25T11:17:40Z

Not sure why PHPStan analysis have failed.

paulbalandan · 2026-04-25T11:24:39Z

You apparently fixed (or renamed) the affected code. Just run composer phpstan:baseline to update the baseline.

michalsn

Supporting a more convenient API would be nice:

incrementAll(['one', 'two'], 2)
incrementAll(['one' => 2, 'two' => 3])

What do you think?

Something like:

public function incrementAll(array $columns, int $value = 1): bool
{
    $fields = [];

    if (array_is_list($columns)) {
        foreach ($columns as $column) {
            $column          = $this->db->protectIdentifiers($column);
            $fields[$column] = "{$column} + {$value}";
        }
    } else {
        foreach ($columns as $column => $value) {
            if (! is_int($value)) {
                throw new TypeError(...);
            }

            $column          = $this->db->protectIdentifiers($column);
            $fields[$column] = "{$column} + {$value}";
        }
    }
    
    // ...
}

michalsn · 2026-04-25T16:43:30Z

+        foreach ($columns as $col => $val) {
+            $col          = $this->db->protectIdentifiers($col);
+            $fields[$col] = "{$col} + {$val}";
+        }


Since we no longer have runtime type enforcement for each value, we should add a check manually. Something like:

if (! is_int($val)) { throw new TypeError(sprintf( 'Argument #1 ($columns) must contain only int values, %s given for "%s".', get_debug_type($val), (string) $col, )); }

paulbalandan · 2026-04-26T17:21:50Z

-        if ($this->castTextToInt) {
-            $values = [$column => "CONVERT(VARCHAR(MAX),CONVERT(INT,CONVERT(VARCHAR(MAX), {$column})) - {$value})"];
-        } else {
-            $values = [$column => "{$column} + {$value}"];


Hmm. Comparing this removed L272 against the new L277. It seems an unnoticed bug in decrement if $this->castTextToInt is false. I think this deserves a separate bug fix in develop.

paulbalandan · 2026-04-26T17:24:02Z

+        }

-        $sql = $this->_update($this->QBFrom[0], [$column => "{$column} + {$value}"]);
+        $sql = $this->_update($this->QBFrom[0], $fields);


What if $columns is [] then $fields is also []. Would that cause issues in the SQL? We should do something with that, either throwing or early return. Either way, we need tests to lock in.

paulbalandan · 2026-04-26T17:31:26Z

        $this->seeInDatabase('job', ['name' => 'incremental', 'description' => '8']);
    }

+    public function testIncrementAll(): void


Can you move this test after all increment tests, then replicate the 3 testing done ( base increment test, with value, and reset state). Same goes for decrement.

paulbalandan · 2026-04-26T17:32:22Z

+
+        $this->db->table('task')
+            ->where('name', 'task1')
+            ->incrementAll(['description' => 2, 'priority' => 3]);


Does this accept negative values? If yes, maybe add some to the tests?

paulbalandan · 2026-04-26T17:33:16Z


        :param string $column: The name of the column to increment
-        :param int $value: The amount to increment in the column
+        :param int $value:  The amount to increment in the column


Do you mean to align this with above param?

paulbalandan · 2026-04-26T17:35:32Z

+     * @param array<string, int> $columns An array of column => value pairs to increment.
     */
-    public function increment(string $column, int $value = 1)
+    public function incrementAll(array $columns): bool


I'm rethinking now my suggestion for incrementAll naming. Would it create ambiguity to anyone reading it by function name only on what it is incrementing?

patel-vansh and others added 5 commits April 25, 2026 12:20

feat: update increment and decrement methods to accept multiple colum…

afc7f0c

…ns as input Co-authored-by: Copilot <copilot@github.com>

feat: add task table and related seeder

bff9dc8

docs: Update documentation

9d69905

docs: Make the signature consistent with actual one

77f431a

docs: Remove unnecessary link

a845cf4

github-actions Bot added the 4.8 PRs that target the `4.8` branch. label Apr 25, 2026

paulbalandan reviewed Apr 25, 2026

View reviewed changes

paulbalandan added the breaking change Pull requests that may break existing functionalities label Apr 25, 2026

feat: Added new methods instead of BC

ca4fdf7

Co-authored-by: Copilot <copilot@github.com>

patel-vansh changed the title ~~feat: Add support to increment/decrement multiple columns at once~~ feat: Add incrementAll() and decrementAll() methods to BaseBuilder and other driver specific builders Apr 25, 2026

paulbalandan removed the breaking change Pull requests that may break existing functionalities label Apr 25, 2026

fix: PHPStan errors

acdc974

patel-vansh closed this Apr 25, 2026

patel-vansh reopened this Apr 25, 2026

patel-vansh requested a review from paulbalandan April 25, 2026 12:02

paulbalandan requested a review from michalsn April 25, 2026 12:27

michalsn reviewed Apr 25, 2026

View reviewed changes

paulbalandan reviewed Apr 26, 2026

View reviewed changes

Conversation

patel-vansh commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paulbalandan left a comment

Choose a reason for hiding this comment

Uh oh!

michalsn commented Apr 25, 2026

Uh oh!

patel-vansh commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michalsn commented Apr 25, 2026

Uh oh!

patel-vansh commented Apr 25, 2026

Uh oh!

paulbalandan commented Apr 25, 2026

Uh oh!

michalsn left a comment

Choose a reason for hiding this comment

Uh oh!

michalsn Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

paulbalandan Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

paulbalandan Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

paulbalandan Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

paulbalandan Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

paulbalandan Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

paulbalandan Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

patel-vansh commented Apr 25, 2026 •

edited

Loading

patel-vansh commented Apr 25, 2026 •

edited

Loading