updated metrics for v26.2#23211
Conversation
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
rmloveland
left a comment
rmloveland
left a comment
There was a problem hiding this comment.
LGTM!
(Note for our future selves to reference):
I mostly just sanity-checked for regressions (with Codex's assistance!) and browsed a few pages. I don’t see any metric removals; the only ‘removals’ are actually renames, one-for-one tenant.consumption.* to tenant.sql_usage.* mappings in the Cloud page. Also the new metrics do not appear (yet) to have autogenerated "datadog ID names" but I think that's an issue in the code that generates them, which would be something separate from this PR. Since we're moving to Mintlify soon, I don't think we should bother looking too deeply into optimizing this process anyway
| cockroachdb,abortspanbytes,gauge,"Number of bytes in the abort span | ||
| Shown as byte" | ||
| Shown as byte | ||
| " |
There was a problem hiding this comment.
Are these newlines before the " necessary? They make the diff confusing.
| crdb_dedicated,valcount,gauge,"Count of all values | ||
| Shown as unit | ||
| " | ||
| crdb_cloud,changefeed.backfill.count,gauge,"Number of changefeeds currently executing backfill. Shown as count. |
There was a problem hiding this comment.
This file mixes crdb_dedicated and crdb_cloud metrics in a file that's called datadog-crdb-dedicated.csv which might be confusing.
There was a problem hiding this comment.
We have this page for standard deployment metrics, but I don't think it grabs from this list: Essential Metrics for CockroachDB Standard Deployments
3 participants
Followed the guidance that Florence left behind re: generating metrics data.
Deploy previews for the affected pages:
metrics.ymlandcluster-settings.csvwere produced by running two differentcockroach gencommands against the latest v26.2 release candidatedatadog-cockroachdb.csvanddatadog-crdb-dedicated.csvboth basically involved copy-pasting from the latest datadog pages.crdb_metrics.ymlwas updated from this directory in the managed-service repo (the other two files in there didn't need changing)metrics-cloud.ymlwas updated from this page in the managed-service repomulti-dimensional-metrics.ymlI used Claude to help me find those five that were added (based on contents of the cockroach repo)