Queued
Conversation
As reported in #4886, `metadata.toml` can get get lost if the server crashes at an unfortunate point in time. Do a textbook fsync to mitigate that. While not necessarily preventing the server from starting, the same is advisable for any of the files, so the logic is put in the macro- generated `write` method of typed paths.
gefjon
approved these changes
Apr 28, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #4886,
metadata.tomlcan get get lost if the server crashes at an unfortunate point in time. To mitigate that, makepath_type::writereplace the file atomically, and issuefsyncon the file and enclosing directory.Expected complexity level and risk
1