refactor: snapshot storage now supports multiple databases per project#5
Merged
refactor: snapshot storage now supports multiple databases per project#5
Conversation
14 new tests in trait_tests module: - put inserts/dedupes; isolation across (project_id, database_id) - list ordering and TimeRange filtering (from inclusive, to exclusive) - latest returns None or most recent summary - get(Latest/At/Hash) including key-scoped hash lookup and error on miss - delete_before returns affected count and is key-scoped - legacy save_snapshot and trait put coexist without cross-contamination - synthetic_db_url_hash deterministic and disjoint from real URL hashes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
radim
force-pushed
the
snapshot-store-refactor
branch
from
6967302 to
c5e5523
Compare
Produces ZST compress file
Adds 5 tests covering bits that were untested: - list_keys_returns_distinct_streams_ordered: empty store -> []; three streams with mixed counts -> three distinct keys ordered by (project, database). - complete_key_uses_resolved_database_id_when_set: profile's database_id wins over the snapshot.database fallback. - complete_key_falls_back_to_snapshot_database: <cli> mode (no profile database_id) uses the introspected DB name. - write_snapshot_export_roundtrips: write -> decompress -> parse; asserts the layout and that content_hash + database survive. - write_snapshot_export_isolates_streams: two keys produce two subdirectories, one file each. Extracts the inline export per-snapshot write into write_snapshot_export(out_root, key, snap) so it's unit-testable. Adds tempfile = "3" to dry_run_cli dev-deps. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original PoC for DryRun counted with one database, but in reality a single project uses more than one database. The change continues in the migration from a single URL-hashed history table to a
SnapshotStoreabstraction keyed by (project_id, database_id).Add the storage part for #4