Extract duplicate logic to reduce LOC across C++ and Java#82
Merged
bernardladenthin merged 1 commit intomasterfrom Apr 8, 2026
Merged
Extract duplicate logic to reduce LOC across C++ and Java#82bernardladenthin merged 1 commit intomasterfrom
bernardladenthin merged 1 commit intomasterfrom
Conversation
- jni_helpers.hpp: deduplicate embedding_to_jfloat_array_impl and tokens_to_jint_array_impl via a shared vec_to_jarray_impl template - jllama.cpp: extract require_embedding_support() guard used by embed() and handleEmbeddings() - JsonParameters.java: add mapToJsonObject() utility for map-to-JSON serialization, used by both setChatTemplateKwargs implementations - InferenceParameters.java: extract buildBiasPairArray() and buildDisablePairArray() helpers to deduplicate four near-identical token bias serialization methods https://claude.ai/code/session_01AGrb17h4jLeWr1de6RGubX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01AGrb17h4jLeWr1de6RGubX