Feature/offers a portable implementation version with import std support by ClausKlein · Pull Request #53 · bemanproject/scope

ClausKlein · 2026-01-14T09:47:42Z

This offers a portable implementation version that compiles on all OS with all C++23 compilers

Refactory CXX_MODULE according to Daniela advice
Quickfix: do not use the old implementation
Autoupdate pre-commit hooks
Use import std; too
Build always an interface library

TODO:

Windows DLL no lib found
Linker problems with gcc on OSX
Linker problems with clang Debug on CI

NOTE: This version compiles on OSX with apple-clang, llvm-clang, and g++-15 too!

Following Issues will be fixed:

I have been prepared export headers to test with DLL's on Windows too.

see https://discourse.cmake.org/t/linker-error-with-cxx-modules/15449

and portable C++ feature checks

This compiles with clang++-21 on OSX and should build on Windows too.

Add more test for unique_resource

scope_exit does not need to be move-assignable!

add get_version() to CXX_MODULE to export some code;

This is needed if only an interface library is build

Prevent warning: placeholder variables are a C++2c extension

ClausKlein · 2026-01-27T18:21:02Z

+
+    include(GenerateExportHeader)
+
+    generate_export_header(
+        beman.scope
+        BASE_NAME beman.scope
+        EXPORT_FILE_NAME beman/scope/modules_export.hpp
+    )
+else()
+    add_library(beman.scope INTERFACE)
+endif()
+
+if(CMAKE_CXX_SCAN_FOR_MODULES)


@JeffGarland For windows DLL do we need an export header too?

The implementation isn't currently supported on msvc. However when it is there would only be a dll for modules I guess

Quickfix: do not use the old implementation Autoupdate pre-commit hooks

ClausKlein · 2026-02-27T20:56:51Z

+#ifdef BEMAN_SCOPE_USE_DANIELA_ADVICE
+    #define BEMAN_SCOPE_MODULE_EXPORT export
+    #define BEMAN_SCOPE_MODULE_BEGIN_EXPORT export {
+    #define BEMAN_SCOPE_MODULE_END_EXPORT }
+
+    // If you define BEMAN_SCOPE_ATTACH_TO_GLOBAL_MODULE
+    //  - all declarations are detached from module 'beman.scope'
+    //  - the module behaves like a traditional static library, too
+    //  - all library symbols are mangled traditionally
+    //  - you can mix TUs with either importing or #including the {beman.scope} API
+    #ifdef BEMAN_SCOPE_ATTACH_TO_GLOBAL_MODULE
+extern "C++" {
+    #endif
+
+// NOTE: this export all implementation details too! CK
+export {
+
+    // FIXME: warning: '#include <filename>' attaches the declarations to the named
+    // module 'beman.scope', which is not usually intended; consider moving that
+    // directive before the module declaration [-Winclude-angled-in-module-purview]
+
+    #include <beman/scope/scope_impl.hpp>
+
+} // end of export
+
+    #ifdef BEMAN_SCOPE_ATTACH_TO_GLOBAL_MODULE
+}
+    #endif
+
+#else
+// ==========================================================
+// Note: not needed because of using `module attachment`!
+// ==========================================================
+


This works at least without import std;

ClausKlein · 2026-02-27T20:59:10Z

+#ifdef BEMAN_SCOPE_USE_FALLBACK
+    #if __has_include("beman/scope/modules_export.hpp")
+        #include "beman/scope/modules_export.hpp"
+    #else
+        #define BEMAN_SCOPE_EXPORT
+    #endif
+
+    #include <exception>
+    #include <type_traits>
+    #include <utility>
+
+namespace beman::scope {


NOTE: this works with verify_interface_headers too;
BUT only if we have two explicit targets: one lib with cxx_module and one interface (header only lib)

coveralls · 2026-02-28T19:06:54Z

coverage: 96.296% (-3.7%) from 100.0%
when pulling a3e4d2e on ClausKlein:feature/add-windows-ci
into 3a82932 on bemanproject:main.

CMAKE_EXPERIMENTAL_CXX_IMPORT_STD is still needed Build and install always a header only lib Fix some clang-tidy warnings pre-commit autoupdate

JeffGarland · 2026-04-25T18:09:52Z

-    list(APPEND ALL_EXAMPLES scope-module)
+include(../cmake/prelude.cmake)
+
+project(beman.scope.example LANGUAGES CXX)


are we doing this in exemplar now, because I don't think we are

JeffGarland · 2026-04-25T18:10:27Z

 // scope exit: true success: true fail: false

-// #ifdef HAS_MODULE_STD
+// NOTE: not included in gcc-15 libstdc++ std module? CK


I think to get cassert you need std.compat

JeffGarland · 2026-04-25T18:13:10Z

-#if __cplusplus < 202002L
+#include <version>
+
+#if defined(__cpp_concepts) && __cpp_concepts >= 201907L


does this work on msvc? maybe it's only the c++ version that doesnt?

ClausKlein added 9 commits January 10, 2026 18:50

Add Windows CI build too

459fbdc

Use portable C++20 check

f3c5c4a

and portable C++ feature checks

Use C++23 on Windows

9ad29b7

Quickfix to compile with C++23

01a4dcf

Add simple BEMAN_SCOPE_USE_FALLBACK code

6f75603

This compiles with clang++-21 on OSX and should build on Windows too.

Fix Windows CI test directory

d83e3f4

Refactory unique_resource code to be portable

2f5ab94

Add more test for unique_resource

Prevent use of explicit operator bool() const noexcept

4a9894d

Test appleclang on CI too

7d92b09

ClausKlein requested review from JeffGarland, neatudarius, robert-andrzejuk and wusatosi as code owners January 14, 2026 09:47

This was referenced Jan 15, 2026

Build errors on OSX #36

Open

make an independent implementation of unique_resource #28

Open

ClausKlein added 2 commits January 15, 2026 21:35

Deleted move assignment operators

58335ff

scope_exit does not need to be move-assignable!

Try to BUILD_SHARED_LIBS on windows

1a86a99

add get_version() to CXX_MODULE to export some code;

ClausKlein force-pushed the feature/add-windows-ci branch from 350bcd8 to 1a86a99 Compare January 15, 2026 21:05

ClausKlein added 2 commits January 15, 2026 23:38

Use GenerateExportHeader cmake module

8c63627

Quickfix for missing export header

f51bfa4

This is needed if only an interface library is build

ClausKlein force-pushed the feature/add-windows-ci branch from 79cd72c to f51bfa4 Compare January 16, 2026 23:09

ClausKlein added 2 commits January 17, 2026 16:23

Use ctest --build-and-test to check the installed version

c9197e6

The final cut

7af734d

Prevent warning: placeholder variables are a C++2c extension

ClausKlein force-pushed the feature/add-windows-ci branch from 26120f1 to 7af734d Compare January 17, 2026 18:52

Prevent use of std::print() for now

3c99179

ClausKlein commented Jan 18, 2026

View reviewed changes

Comment thread CMakeLists.txt Outdated

Add infra submodule and use it

9b63207

ClausKlein self-assigned this Jan 27, 2026

ClausKlein commented Jan 27, 2026

View reviewed changes

Comment thread infra/.beman_submodule Outdated

ClausKlein commented Jan 27, 2026

View reviewed changes

Comment thread infra/.pre-commit-config.yaml Outdated

infra/tools/beman-submodule/beman-submodule update

38f5da3

ClausKlein commented Jan 27, 2026

View reviewed changes

ClausKlein force-pushed the feature/add-windows-ci branch from 86c2cfa to c0e2002 Compare February 27, 2026 10:15

Refactory CXX_MODULE according to Daniela advice

3d810f1

Quickfix: do not use the old implementation Autoupdate pre-commit hooks

ClausKlein force-pushed the feature/add-windows-ci branch from 6475182 to 3d810f1 Compare February 27, 2026 20:36

ClausKlein requested review from camio, dietmarkuehl and ednolan February 27, 2026 20:50

ClausKlein commented Feb 27, 2026

View reviewed changes

ClausKlein changed the title ~~Feature/add windows ci~~ Feature/offers a portable implementation version with import std support Feb 28, 2026

Next steps with import std;

4a35cc4

CMAKE_EXPERIMENTAL_CXX_IMPORT_STD is still needed Build and install always a header only lib Fix some clang-tidy warnings pre-commit autoupdate

ClausKlein force-pushed the feature/add-windows-ci branch from 743105f to 4a35cc4 Compare March 3, 2026 10:31

Try to prevent linker problems on OSX with gcc-15

5c6aa81

ClausKlein requested review from msvetkin, nickelpro and steve-downey March 3, 2026 12:10

ClausKlein added 2 commits March 25, 2026 19:37

Use beman_install_library() cmake function

cfca6f4

Merge branch 'main' into feature/add-windows-ci

a3e4d2e

JeffGarland reviewed Apr 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/offers a portable implementation version with import std support#53

Feature/offers a portable implementation version with import std support#53
ClausKlein wants to merge 23 commits intobemanproject:mainfrom
ClausKlein:feature/add-windows-ci

ClausKlein commented Jan 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ClausKlein Jan 27, 2026 •

edited

Loading

Uh oh!

JeffGarland Apr 25, 2026 •

edited

Loading

Uh oh!

ClausKlein Feb 27, 2026

Uh oh!

ClausKlein Feb 27, 2026 •

edited

Loading

Uh oh!

coveralls commented Feb 28, 2026 •

edited

Loading

Uh oh!

JeffGarland Apr 25, 2026

Uh oh!

JeffGarland Apr 25, 2026

Uh oh!

JeffGarland Apr 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ClausKlein commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO:

NOTE: This version compiles on OSX with apple-clang, llvm-clang, and g++-15 too!

I have been prepared export headers to test with DLL's on Windows too.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ClausKlein Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JeffGarland Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ClausKlein Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

ClausKlein Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JeffGarland Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

JeffGarland Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

JeffGarland Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ClausKlein commented Jan 14, 2026 •

edited

Loading

ClausKlein Jan 27, 2026 •

edited

Loading

JeffGarland Apr 25, 2026 •

edited

Loading

ClausKlein Feb 27, 2026 •

edited

Loading

coveralls commented Feb 28, 2026 •

edited

Loading