fix: make local mode health-check timeout configurable via session config#5778
Open
egorkosaretsky wants to merge 1 commit intoaws:masterfrom
Open
fix: make local mode health-check timeout configurable via session config#5778egorkosaretsky wants to merge 1 commit intoaws:masterfrom
egorkosaretsky wants to merge 1 commit intoaws:masterfrom
Conversation
…nfig (aws#3362) Allow users to set `local.health_check_timeout` in their session config to override the hard-coded 120s limit, fixing failures when large model archives or slow networks cause container startup to exceed the default. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
egorkosaretsky
requested a deployment
to
manual-approval
GitHub Actions
Waiting
egorkosaretsky
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Local mode endpoint deployment uses a hard-coded
HEALTH_CHECK_TIMEOUT_LIMITof 120s (entities.py:43). This causes failures when containers take longer to start — e.g. large model archives (~5GB+), slow pip installs, or low-bandwidth environments — even though the actual SageMaker endpoint deployment succeeds fine.Fixes #3362.
Solution
timeoutparameter to_wait_for_serving_container()(defaults toHEALTH_CHECK_TIMEOUT_LIMITfor backwards compatibility)_LocalEndpoint.serve()and_LocalTransformJob.start()now readlocal.health_check_timeoutfrom the session config and pass it throughUsage:
Testing
Added unit tests covering:
_wait_for_serving_containerhealth_check_timeoutfrom session config is passed through in_LocalEndpoint.serve()Checklist