feat: add support for ruby 4.0 #855
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -322,7 +322,7 @@ jobs: | |
| - run: pytest -vv tests/integration/workflows/python_uv | ||
|
|
||
| ruby-integration: | ||
| name: ${{ matrix.os }} / ${{ matrix.python }} / ruby ${{ matrix.ruby }} | ||
| if: github.repository_owner == 'aws' | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
|
|
@@ -333,14 +333,17 @@ jobs: | |
| - windows-latest | ||
| python: | ||
| - "3.13" | ||
| ruby: | ||
| - "3.2" | ||
| - "4.0" | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| - uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: ${{ matrix.python }} | ||
| - uses: ruby/setup-ruby@4dc28cf14d77b0afa6832d9765ac422dbf0dfedd # v1 | ||
| with: | ||
| ruby-version: ${{ matrix.ruby }} | ||
| - run: make init | ||
| - run: pytest -vv tests/integration/workflows/ruby_bundler | ||
|
Contributor
There was a problem hiding this comment. It's interesting that we use every these two versions of ruby (3.2, 4.0) to check that lambda-builders can build every version of ruby (from the One would think that we just need to build each version with the same version, but this is a more complete test (assuming that the test is real and it's actually building for each of the different ruby versions instead of just using the ruby from the environment and ignoring the runtime passed as a parameter.. in that case, we would be running the same test 4 times... so hopefully this all works how it's supposed to, and we have a very good test)
Contributor
Author
There was a problem hiding this comment. I don't remember too well, but I think I had previously considered this issue when working on #808. I think you might be right (unfortunately) that we're running tests for functions with runtimes that are supposedly 3.4 or 3.6, but it's just in an environment that doesn't even have that version. I think that's non-blocking for this PR, but probably requires some more testing. |
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,6 +32,7 @@ | |
| "ruby3.2", | ||
| "ruby3.3", | ||
| "ruby3.4", | ||
| "ruby4.0", | ||
| ] | ||
|
|
||
| # Java runtimes | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ | |
| ("ruby3.2",), | ||
| ("ruby3.3",), | ||
| ("ruby3.4",), | ||
| ("ruby4.0",), | ||
| ], | ||
| ) | ||
| class TestRubyWorkflow(TestCase): | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create for ruby3.2 is actually supposed to be deprecated April 30, can we remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on what I see here function create is blocked 2026-08-31 and function update is blocked on 2026-09-30. My understanding is we usually don't remove runtimes until their update is blocked.