Fixes #789 - email_verified can be a string or boolean#831
Closed
timgates42 wants to merge 4 commits intoauth0:masterfrom
Closed
Fixes #789 - email_verified can be a string or boolean#831timgates42 wants to merge 4 commits intoauth0:masterfrom
timgates42 wants to merge 4 commits intoauth0:masterfrom
Conversation
Add extra types so a non-empty string is treated as true but an empty string is treated as false
timgates42
changed the title
timgates42
changed the title
Author
|
Fixes #789 |
The linter finally got its way. Import ordering across the authentication and management modules was brought into line with ruff's expectations, because apparently alphabetical order is the hill we die on. Blank lines that contributed nothing but existential whitespace were also removed. Nobody mourned them. 🪦 The pre-commit configuration was migrated from remote repository hooks to local system-level hooks for both ruff and ggshield. This means builds no longer depend on fetching specific tagged versions from GitHub at hook install time — the locally installed tools are used directly instead. One less thing to break on a Monday morning. 🔧 A minor formatting adjustment landed in the UserResponseSchema where a long pydantic.Field call was wrapped to respect line length limits. The .gitignore also picked up an entry for error.txt and had its missing trailing newline restored, because even config files deserve a proper ending. 📝 Test files received the same import-sorting treatment. No logic changed, no assertions were harmed — just imports shuffled into the order the linter demanded. The tests still pass, the code still works, and the diff is mostly whitespace. Such is the life of a codebase under the watchful eye of automated formatting. 🤖 Signed-off-by: Tim Gates <tim.gates@iress.com>
Contributor
|
@timgates42 Thanks for the PR. The underlying issue is valid, SAML connections can return a string for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add extra types so a non-empty string is treated as true but an empty string is treated as false
Changes
What is changing and why this is important:
References
Rrelevant links supporting this change:
Testing
This item can be tested by setting up a SAML connection where the email_verified is mapped to the email field and then retrieving the user details for a user that logs in over this connection.
Checklist