Fix expanding template expressions from defaultDestination for CLI install #822
Merged
dbreshears merged 4 commits intoaspnet:mainfrom Apr 21, 2026
Merged
Fix expanding template expressions from defaultDestination for CLI install #822dbreshears merged 4 commits intoaspnet:mainfrom
dbreshears merged 4 commits intoaspnet:mainfrom
Conversation
When originally added, it was only expanded when we were loading the LibraryInstallationState from disk/JSON to memory. In the CLI install scenario, we want to apply the same expansion when the LibraryInstallationState is generated from parameters (not read from disk). Note: only the defaultDestination value is allowed to use templated values. Also cleaned up some confusing or redundant checks for the installation destination in the CLI Install command. It now has a simpler flow to allow null/empty values if there is a default specified.
dbreshears
reviewed
Feb 12, 2026
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Linq; |
Member
There was a problem hiding this comment.
Looks like this can be removed
Contributor
Author
There was a problem hiding this comment.
Needed for net481 (for string.Contains(char))
dbreshears
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the same expansion when installing libraries whether the manifest is from disk or generated in memory. (CLI updates the manifest on disk after the install succeeds.)
Some extras:
Resolves #821