Skip to content

support refactored json format#34

Merged
efectn merged 3 commits intomasterfrom
json-format-v2
Dec 20, 2025
Merged

support refactored json format#34
efectn merged 3 commits intomasterfrom
json-format-v2

Conversation

@efectn
Copy link
Copy Markdown
Member

@efectn efectn commented Dec 20, 2025

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The PR adds internal handling for external HTTP(S) redirects in http.go by introducing an isLink flag and using the raw URL for Location headers when the map entry is an absolute HTTP(S) link; URL construction and host override are skipped for such links. In map.go the ReleaseFile struct gains three new fields (FileURLASC, FileURLSHA, FileURLTorrent) and loadMapJSON is updated to populate variant-specific map entries from those fields instead of deriving variant URLs by appending extensions. map_test.go is updated with richer asset fixtures and expected values to exercise the new URL fields.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~40 minutes

  • Review map.go changes thoroughly: new struct fields, JSON loading logic, and variant-entry generation to ensure no duplicate keys and backward compatibility.
  • Inspect map_test.go updates: validate test fixtures, expected map keys and URL values align with loader behavior.
  • Check http.go redirect logic: isLink flag handling, Location header selection, and host-override conditions.
  • Verify integration points between map entries and redirect resolution (edge cases for mixed absolute and relative URLs).

Possibly related PRs

Suggested reviewers

  • igorpecovnik

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate whether the description relates to the changeset. Add a description explaining the changes: what the refactored JSON format supports (new file variant URLs), why this change was made, and what impact it has on the codebase.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'support refactored json format' accurately describes the main changes across the PR, which involve expanding JSON schemas in map.go and http.go to handle additional file format variants (ASC, SHA, TORRENT).
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 902370f and 315a083.

📒 Files selected for processing (3)
  • http.go (4 hunks)
  • map.go (2 hunks)
  • map_test.go (5 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot requested a review from igorpecovnik December 20, 2025 18:54
@efectn efectn merged commit fe5b11d into master Dec 20, 2025
1 of 2 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant