Skip to content

Revert "fix: gate documentsdb/vectorsdb list calls behind multi-db flag"#2994

Merged
HarshMN2345 merged 1 commit intomainfrom
revert-2991-feat-documentsdb
Apr 23, 2026
Merged

Revert "fix: gate documentsdb/vectorsdb list calls behind multi-db flag"#2994
HarshMN2345 merged 1 commit intomainfrom
revert-2991-feat-documentsdb

Conversation

@HarshMN2345
Copy link
Copy Markdown
Member

Reverts #2991

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 23, 2026

Greptile Summary

This PR reverts #2991, which had gated documentsDB.list and vectorsDB.list calls behind the multiDb feature flag. The revert restores the unconditional Promise.all over all three SDK list calls.

  • The removed flag check prevents Promise.all from rejecting when documentsDB/vectorsDB endpoints are unavailable for users without multi-db access — without the guard, any API error from those endpoints will break the entire database listing page for affected users.

Confidence Score: 3/5

Potentially unsafe to merge without confirming that documentsDB/vectorsDB endpoints are available to all users.

The removed guard could cause Promise.all to reject for users without multi-db access, breaking the primary database listing flow. The PR needs confirmation that the multi-db feature is universally enabled before the flag guard can be safely dropped.

src/routes/(console)/project-[region]-[project]/databases/database-[database]/(entity)/helpers/sdk.ts — specifically the list method

Important Files Changed

Filename Overview
src/routes/(console)/project-[region]-[project]/databases/database-[database]/(entity)/helpers/sdk.ts Reverts multi-db flag guard: documentsDB.list and vectorsDB.list are now always called, risking failures for users without multi-db access

Reviews (1): Last reviewed commit: "Revert "fix: gate documentsdb/vectorsdb ..." | Re-trigger Greptile

Comment on lines +176 to +180
const results = await Promise.all([
baseSdk.tablesDB.list(params),
baseSdk.documentsDB.list(params),
baseSdk.vectorsDB.list(params)
]);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Unconditional documentsDB/vectorsDB calls may break list for non-multi-db users

The reverted guard ensured documentsDB.list and vectorsDB.list were only called when the multiDb feature flag was active. Without it, these two API calls are issued unconditionally. If either endpoint returns an error (e.g. 404/403) for projects that don't have multi-db enabled, Promise.all will reject and the entire databases list page will fail to load — users would see no databases at all. Is the multi-db flag now fully rolled out for all users, making this guard unnecessary?

@HarshMN2345 HarshMN2345 merged commit 31c2246 into main Apr 23, 2026
3 of 4 checks passed
@HarshMN2345 HarshMN2345 deleted the revert-2991-feat-documentsdb branch April 23, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants