Revert "fix: gate documentsdb/vectorsdb list calls behind multi-db flag"#2994
Revert "fix: gate documentsdb/vectorsdb list calls behind multi-db flag"#2994HarshMN2345 merged 1 commit intomainfrom
Conversation
Greptile SummaryThis PR reverts #2991, which had gated
Confidence Score: 3/5Potentially unsafe to merge without confirming that documentsDB/vectorsDB endpoints are available to all users. The removed guard could cause src/routes/(console)/project-[region]-[project]/databases/database-[database]/(entity)/helpers/sdk.ts — specifically the Important Files Changed
Reviews (1): Last reviewed commit: "Revert "fix: gate documentsdb/vectorsdb ..." | Re-trigger Greptile |
| const results = await Promise.all([ | ||
| baseSdk.tablesDB.list(params), | ||
| baseSdk.documentsDB.list(params), | ||
| baseSdk.vectorsDB.list(params) | ||
| ]); |
There was a problem hiding this comment.
Unconditional documentsDB/vectorsDB calls may break list for non-multi-db users
The reverted guard ensured documentsDB.list and vectorsDB.list were only called when the multiDb feature flag was active. Without it, these two API calls are issued unconditionally. If either endpoint returns an error (e.g. 404/403) for projects that don't have multi-db enabled, Promise.all will reject and the entire databases list page will fail to load — users would see no databases at all. Is the multi-db flag now fully rolled out for all users, making this guard unnecessary?
Reverts #2991