Skip to content

fix: Fix StorageInstanceManager cache eviction#1855

Merged
janbuchar merged 1 commit intomasterfrom
fix-storage-manager-cache-eviction
Apr 23, 2026
Merged

fix: Fix StorageInstanceManager cache eviction#1855
janbuchar merged 1 commit intomasterfrom
fix-storage-manager-cache-eviction

Conversation

@janbuchar
Copy link
Copy Markdown
Collaborator

  • See the added test to understand the problematic scenario.
  • There is a good chance that this wouldn't cause any problems in practice, but better safe than sorry.

@janbuchar janbuchar added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Apr 23, 2026
@janbuchar janbuchar requested review from Pijukatel and vdusek April 23, 2026 09:24
@github-actions github-actions Bot added this to the 139th sprint - Tooling team milestone Apr 23, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Apr 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.34%. Comparing base (b80f562) to head (d49265a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1855      +/-   ##
==========================================
- Coverage   92.41%   92.34%   -0.08%     
==========================================
  Files         158      158              
  Lines       11009    11009              
==========================================
- Hits        10174    10166       -8     
- Misses        835      843       +8     
Flag Coverage Δ
unit 92.34% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janbuchar janbuchar merged commit 983f14f into master Apr 23, 2026
32 checks passed
@janbuchar janbuchar deleted the fix-storage-manager-cache-eviction branch April 23, 2026 11:53
janbuchar added a commit to apify/crawlee that referenced this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants