Conversation
…tests Shared request queue propagation (issue #808) occasionally exceeds the current 7s budget (1+2+4), causing flakes like `test_request_ordering_with_mixed_operations[shared]`. Bumping `max_retries` from 3 to 5 extends the worst-case wait to ~31s while adding no cost in the happy path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #876 +/- ##
==========================================
+ Coverage 86.57% 86.64% +0.06%
==========================================
Files 48 48
Lines 2920 2920
==========================================
+ Hits 2528 2530 +2
+ Misses 392 390 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_request_ordering_with_mixed_operations[shared]failed on CI becausefetch_next_requestreturnedNoneafter all retries. The test already wraps the call incall_with_exp_backoff, but the helper's defaultmax_retries=3only allows 1+2+4 = 7s of backoff — shared RQ propagation delay (see #808) occasionally exceeds that.Raising the default to
max_retries=5extends the worst-case wait to 1+2+4+8+16 = 31s. No cost in the happy path (returns on the first successful call), and the change benefits all 37 call sites of the helper.Failed CI run: https://github.com/apify/apify-sdk-python/actions/runs/24673724360/job/72151584275
🤖 Generated with Claude Code