Conversation
`AliasResolver._get_alias_map` used `not cls._alias_map` as a 'not loaded' sentinel, conflating an empty dict with 'not yet loaded' and re-hitting the default KVS on every lookup until the first alias was persisted. It also gated `is_at_home` on `Configuration.get_global_configuration()` while the KVS client was built from `self._configuration`, so an injected custom configuration could silently skip writes or target the wrong KVS. Introduce a `_alias_map_loaded` sentinel and use the injected configuration consistently for both gating and client construction. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #874 +/- ##
===========================================
- Coverage 86.57% 75.73% -10.84%
===========================================
Files 48 48
Lines 2920 2922 +2
===========================================
- Hits 2528 2213 -315
- Misses 392 709 +317
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Apr 21, 2026
vdusek
deleted the
fix/alias-resolver-load-sentinel-and-config-consistency
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AliasResolverhad two consistency issues:if not cls._alias_mapconflated an empty dict with 'not yet loaded', so every alias lookup re-hit the default KVS withget_recorduntil the first alias was persisted.is_at_homewas read from the globalConfigurationwhile the KVS client was built fromself._configuration, so a caller-injected config could silently skip writes or target the wrong KVS.Fix
_alias_map_loadedsentinel so an empty KVS response counts as 'loaded'.is_at_homegating and KVS client construction.