test: fix flaky test_get_request_by_unique_key[shared]#873
Merged
Conversation
The test called `rq.get_request` immediately after `rq.add_request` without retry, which races against the shared request queue propagation delay. Wrap the lookup in `call_with_exp_backoff` like the rest of the file. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #873 +/- ##
==========================================
+ Coverage 86.57% 86.64% +0.06%
==========================================
Files 48 48
Lines 2920 2920
==========================================
+ Hits 2528 2530 +2
+ Misses 392 390 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_get_request_by_unique_key[shared]calledrq.get_requestimmediately afterrq.add_request, which races against the shared request queue's propagation delay and caused intermittent CI failures (e.g. this run).Wrapped the lookup in
call_with_exp_backoff, matching the pattern used by every other test in the file (see top-of-file comment referencing #808). The subsequent negative lookup (non-existent-unique_key) is intentionally left as a direct call — it expectsNone, so retrying would just burn 7s of backoff for no benefit.🤖 Generated with Claude Code