fix: honor event_listeners_timeout in Actor.reboot#872
Merged
Conversation
The `event_listeners_timeout` parameter was previously ignored, allowing a hanging pre-reboot listener to block the reboot indefinitely. Wrap listener execution in `asyncio.wait_for` so the reboot proceeds once the timeout elapses. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #872 +/- ##
==========================================
- Coverage 86.64% 86.59% -0.06%
==========================================
Files 48 48
Lines 2920 2924 +4
==========================================
+ Hits 2530 2532 +2
- Misses 390 392 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
On Python 3.10, `asyncio.wait_for` raises `asyncio.TimeoutError` (an alias for `concurrent.futures.TimeoutError`), which is a distinct class from the builtin `TimeoutError`. The aliasing only became true in Python 3.11. Using the `asyncio.TimeoutError` name works on all supported Python versions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pijukatel
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
event_listeners_timeoutparameter ofActor.rebootwas previously ignored (marked# noqa: ARG002), which meant a hanging pre-reboot listener could block the reboot indefinitely. This change wraps listener execution inasyncio.wait_forso the reboot proceeds once the timeout elapses, logging a warning in that case.Added a unit test that verifies the reboot is not blocked by a listener that exceeds the timeout.