fix: treat naive datetime query params as UTC#752
Merged
Conversation
Calling `.astimezone(UTC)` on a naive datetime presumed the host's local timezone and produced a timestamp with a misleading `Z` suffix, silently corrupting timestamp filters (e.g. `started_before`/`started_after`) on non-UTC hosts. Attach UTC explicitly when `tzinfo` is missing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #752 +/- ##
==========================================
- Coverage 95.45% 95.22% -0.24%
==========================================
Files 45 45
Lines 5125 5126 +1
==========================================
- Hits 4892 4881 -11
- Misses 233 245 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpClientBase._parse_paramscalled.astimezone(UTC)directly on incomingdatetimevalues. Per Python's stdlib, a naive datetime is presumed to represent time in the system's local timezone, so on a non-UTC host the value was shifted by the host's offset and then serialized with aZsuffix — a wire format that looks like UTC but isn't. This silently corrupted timestamp filters such asstarted_before/started_afteronruns().list()whenever a caller passed a naive datetime.The fix attaches
UTCto the value whentzinfois missing, so naive datetimes round-trip as UTC instead of being relocalized.Added a unit test that pins
TZ=Asia/Karachiwithtime.tzset()to reproduce the bug deterministically on Unix CI (skipped on Windows, wheretime.tzsetis unavailable).