refactor(symfony): remove static state from EntrypointAction#7919
Merged
soyuka merged 1 commit intoapi-platform:4.3from Apr 27, 2026
Merged
Conversation
…er mode compatibility
02ecd93 to
6cf2ab5
Compare
Member
|
good catch thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request is the first step of the worker mode compatibility audit (see #7918). It addresses the usage of
staticproperties for state persistence within Symfony Actions.In persistent memory runtimes like FrankenPHP or Swoole,
staticproperties persist across the entire process lifetime. In the case ofEntrypointAction, storing theResourceNameCollectionin a static property is unnecessary since the service is already a singleton in the container.Moving this to an instance property ensures:
Changes
staticscope from$resourceNameCollectioninEntrypointAction.__invoketo use instance-level lazy loading with the??=operator.Context
This fix is part of a global audit performed with Igor-PHP.
Part of #7918