bug: NoopCatalog should return False, not throw error#3284
Merged
geruh merged 1 commit intoapache:mainfrom Apr 25, 2026
Merged
Conversation
ebyhr
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is a little niche.
StaticTable uses NoopCatalog under the hood. If you attempt to call
plan_files, it'll try to callNoopCatalog.should_use_server_side_planning...which immediately throws an error.Intuitively, this fix should make sense. Why would I throw an error when I can just return False? NoopCatalog does not support server side planning!
Are these changes tested?
Tests should still pass.
Are there any user-facing changes?