Skip to content

ci: optimize rerun workflow and add macOS RocksDB coverage#3010

Open
contrueCT wants to merge 5 commits intoapache:masterfrom
contrueCT:task/optimize-rerun-ci
Open

ci: optimize rerun workflow and add macOS RocksDB coverage#3010
contrueCT wants to merge 5 commits intoapache:masterfrom
contrueCT:task/optimize-rerun-ci

Conversation

@contrueCT
Copy link
Copy Markdown
Contributor

Purpose of the PR

Optimize the Rerun CI workflow so it only starts the rerun decision job when an upstream CI workflow actually fails.

Previously, the rerun workflow also ran for non-failure conclusions and then skipped inside the shell script, which created unnecessary workflow runs.

Main Changes

  • Add a job-level condition to decide-rerun-action:
    • only run when github.event.workflow_run.conclusion == 'failure'
  • Remove the redundant CONCLUSION shell variable and non-failure branch handling
  • Keep the existing rerun behavior unchanged for supported events:
    • push
    • pull_request
  • Keep the existing retry limit, delay, permissions, and gh run rerun --failed behavior unchanged

Verifying these changes

  • Confirmed the change only affects .github/workflows/rerun-ci.yml
  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • Ran git diff --check -- .github/workflows/rerun-ci.yml

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. ci-cd Build or deploy labels Apr 26, 2026
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 26, 2026
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 26, 2026
@contrueCT contrueCT changed the title ci: only evaluate rerun workflow for failed CI runs ci: optimize rerun workflow and add macOS RocksDB coverage Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd Build or deploy size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant