Skip to content

User vm manager cleanup #12779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DaanHoogland wants to merge 12 commits into
base: 4.22
Choose a base branch
from

another pre-existing pre-commit issue

61b451c
Select commit
Loading
Failed to load commit list.
Open

User vm manager cleanup #12779

another pre-existing pre-commit issue
61b451c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 17, 2026 in 7m 7s

Quality Gate failed

Failed conditions
12.5% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check failure on line 6311 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZzXUovIu3gSuYsfDs2B&open=AZzXUovIu3gSuYsfDs2B&pullRequest=12779

Check warning on line 460 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_routerDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ2bNGK31Y673cLxgW09&open=AZ2bNGK31Y673cLxgW09&pullRequest=12779

Check failure on line 470 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZzXUoz1u3gSuYsfDs2C&open=AZzXUoz1u3gSuYsfDs2C&pullRequest=12779

Check warning on line 8951 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZzXUovIu3gSuYsfDs12&open=AZzXUovIu3gSuYsfDs12&pullRequest=12779

Check failure on line 9298 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use static access with "org.apache.commons.lang3.StringUtils" for "isEmpty". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZzj7pKXs2yxA_6A-Mm9&open=AZzj7pKXs2yxA_6A-Mm9&pullRequest=12779

Check warning on line 5580 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0-cn7R1XV5X7Zc16mO&open=AZ0-cn7R1XV5X7Zc16mO&pullRequest=12779

Check failure on line 1448 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 22 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZzXUovIu3gSuYsfDs17&open=AZzXUovIu3gSuYsfDs17&pullRequest=12779

Check warning on line 463 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_virtualNetAppliance" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ2bNGK31Y673cLxgW0-&open=AZ2bNGK31Y673cLxgW0-&pullRequest=12779

Check warning on line 457 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_vmNetworkMapDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ2bNGK31Y673cLxgW08&open=AZ2bNGK31Y673cLxgW08&pullRequest=12779

Check warning on line 8074 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 8 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZzXUovIu3gSuYsfDs15&open=AZzXUovIu3gSuYsfDs15&pullRequest=12779

Check failure on line 1675 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 25 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZzXUovIu3gSuYsfDs18&open=AZzXUovIu3gSuYsfDs18&pullRequest=12779

Check failure on line 2028 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 33 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZzXUovIu3gSuYsfDs19&open=AZzXUovIu3gSuYsfDs19&pullRequest=12779
View more details on SonarQubeCloud