fix: Ensure dummy server is stopped on program exit#3281
Closed
condy0919 wants to merge 1 commit intoapache:masterfrom
Closed
fix: Ensure dummy server is stopped on program exit#3281condy0919 wants to merge 1 commit intoapache:masterfrom
condy0919 wants to merge 1 commit intoapache:masterfrom
Conversation
Add a static `DummyServerStopper` object whose destructor calls the new `StopDummyServer()` function, guaranteeing that the dummy server is properly stopped and joined when the program exits. Also make `g_dummy_server` an atomic pointer with explicit memory ordering to ensure safe access across threads, and provide the public `StopDummyServer()` API for explicit cleanup if needed. Fix apache#3280
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve #3280
Problem Summary:
What is changed and the side effects?
Changed:
Add a static
DummyServerStopperobject whose destructor calls the newStopDummyServer()function, guaranteeing that the dummy server is properly stopped and joined when the program exits.Also make
g_dummy_serveran atomic pointer with explicit memory ordering to ensure safe access across threads, and provide the publicStopDummyServer()API for explicit cleanup if needed.Check List: