fix: multiple --add-dir flags overwrite instead of combining#1221
Open
jakeefr wants to merge 1 commit intoanthropics:mainfrom
Open
fix: multiple --add-dir flags overwrite instead of combining#1221jakeefr wants to merge 1 commit intoanthropics:mainfrom
jakeefr wants to merge 1 commit intoanthropics:mainfrom
Conversation
Add "add-dir" to ACCUMULATING_FLAGS so multiple --add-dir flags accumulate instead of each overwriting the previous. Extract the accumulated values into sdkOptions.additionalDirectories (a first-class SDK property) so the SDK emits separate --add-dir flags for each path. Fixes anthropics#1215 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1215. The
--add-dirflag was typed as a regular (non-accumulating) flag, causing each subsequent--add-dirto overwrite the previous one. Only the last value was used.What changed
parse-sdk-options.ts: Added"add-dir"toACCUMULATING_FLAGS. After parsing, the accumulated values are extracted fromextraArgs, split, and placed intosdkOptions.additionalDirectories(a first-class SDK array property). This follows the same pattern used forallowedToolsanddisallowedTools.parse-sdk-options.test.ts: Added 4 tests covering single--add-dir, multiple--add-dir, mixed with other flags, and absent--add-dir.How it works
Before:
--add-dir "/a" --add-dir "/b"→extraArgs["add-dir"] = "/b"(overwritten)After:
--add-dir "/a" --add-dir "/b"→sdkOptions.additionalDirectories = ["/a", "/b"]→ SDK emits--add-dir /a --add-dir /bTest plan
parse-sdk-optionstests pass (27 existing + 4 new)