Discriminate tool search result union#1395
Open
hwaxxer wants to merge 1 commit intoanthropics:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1394
ToolSearchToolResultBlock.contentis generated as a plain union, but the two variants are discriminated bytype. Without that discriminator metadata,BaseModel.construct()can fall back to the first union member and construct a search result payload asToolSearchToolResultError.This adds the expected discriminator metadata for stable and beta, plus regression coverage.
I realize these files are Stainless-generated, so this PR may not be directly mergeable as-is. I’m submitting it to make the bug and expected generated output concrete.