fix(github-actions): fix issue with milestones not applying#3628
Open
thePunderWoman wants to merge 1 commit intoangular:mainfrom
Open
fix(github-actions): fix issue with milestones not applying#3628thePunderWoman wants to merge 1 commit intoangular:mainfrom
thePunderWoman wants to merge 1 commit intoangular:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to track labels added during the current execution of the issue labeling action, ensuring that subsequent logic accounts for labels that might not yet be reflected in the GitHub API response due to latency. The feedback suggests improving encapsulation by making the addedLabels property private and centralizing the tracking logic by overriding the addLabel method, which would also ensure that all added labels are consistently recorded.
Milestones have not been set properly with the issue triage github action. It is likely due to the api response happening too quickly after labels were applied, and not yet including them. So this manually accounts for the labels we added.
thePunderWoman
force-pushed
the
label-fix
branch
from
3df4cab to
4d91fb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestones have not been set properly with the issue triage github action. It is likely due to the api response happening too quickly after labels were applied, and not yet including them. So this manually accounts for the labels we added.