feat(bazel): add diff output to failing api-golden tests#3627
Open
clydin wants to merge 1 commit intoangular:mainfrom
Open
feat(bazel): add diff output to failing api-golden tests#3627clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
clydin
force-pushed
the
feat/api-golden-diff
branch
from
42e66b4 to
97e2230
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates the diff library to generate and display patches when API golden files are outdated. The reporting logic in index_npm_packages.cts has been updated to include these diffs. The reviewer suggested using console.error consistently for all parts of the failure report to ensure that diagnostic output is correctly handled in environments that separate standard output and standard error.
This commit adds unified diff output when `api_golden_test` fails, using the `diff` NPM package.
clydin
force-pushed
the
feat/api-golden-diff
branch
from
97e2230 to
e7f080e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds unified diff output when
api_golden_testfails, using thediffNPM package.