Use t.buildUndefinedNode instead of Scope#buildUndefinedNode#33020
Merged
clydin merged 2 commits intoangular:mainfrom Apr 17, 2026
Merged
Use t.buildUndefinedNode instead of Scope#buildUndefinedNode#33020clydin merged 2 commits intoangular:mainfrom
t.buildUndefinedNode instead of Scope#buildUndefinedNode#33020clydin merged 2 commits intoangular:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the elide-angular-metadata Babel plugin to utilize the types object provided by the plugin factory for generating undefined nodes, replacing the previous usage of path.scope.buildUndefinedNode(). Feedback suggests adding an explicit type annotation to the destructured types parameter to prevent implicit any types and improve code maintainability.
…e#buildUndefinedNode` Babel 8 is _likely_ going to remove the variant on `Scope#`, since this method has not needed scope-specific information in ages.
alan-agius4
added
the
target: minor
alan-agius4
added
action: merge
…f `Scope#buildUndefinedNode`
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)PR Type
What kind of change does this PR introduce?
What is the current/new behavior?
Babel 8 is likely going to remove the variant on
Scope#, since this method has not needed scope-specific information in ages.Does this PR introduce a breaking change?
This package depends on Babel 7.29.0, which supports
t.buildUndefinedNode.Other information
Ref babel/babel#17937