feat(auth): add confirm password to signup and settings#1265
Merged
Awk34 merged 1 commit intoangular-fullstack:canaryfrom Sep 8, 2015
Merged
feat(auth): add confirm password to signup and settings#1265Awk34 merged 1 commit intoangular-fullstack:canaryfrom
Awk34 merged 1 commit intoangular-fullstack:canaryfrom
Conversation
kingcody
force-pushed
the
feature/confirm-field
branch
2 times, most recently
from
93578fc to
fda8d59
Compare
Collaborator
|
Perhaps it might be better to do this one without an extra bower package? |
Originally submitted by @thomporter Closes angular-fullstack#484
kingcody
force-pushed
the
feature/confirm-field
branch
from
fda8d59 to
ac39051
Compare
Member
Author
|
That was my thought at first, but honestly its would be the same amount of code for us to implement it ourselves. Also there are a decent amount of stars/forks of that module so I'm sure there will be far more eyes on the code in that repo than there ever would be here on that specific piece. |
Awk34
added a commit
that referenced
this pull request
Sep 8, 2015
feat(auth): add confirm password to signup and settings
Collaborator
|
Alright, sounds good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally submitted by @thomporter
Closes #484