don't install header files into subdirectory to match upstream#3
Merged
don't install header files into subdirectory to match upstream#3
Conversation
Techatrix
force-pushed
the
techatrix/fix-install-headers
branch
from
bcc0975 to
884f471
Compare
SoraTenshi
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The include path for capstone v5 installed with pkg-config already includes the
capstonesub directory so that header files can only be included with#include <capstone.h>. This appears to be unintentional and has been changed in capstone v6 to support#include <capstone/capstone.h>.Since Zig is primarily used with pkg-config to lookup system libraries. We should match the pkg-config behavior until this port is updated to v6.
The difference in include paths can be found here: