Skip to content

chore: disable automatic deploy workflows#3

Open
taltas wants to merge 3 commits intomainfrom
chore/disable-workflows
Open

chore: disable automatic deploy workflows#3
taltas wants to merge 3 commits intomainfrom
chore/disable-workflows

Conversation

@taltas
Copy link
Copy Markdown

@taltas taltas commented Apr 25, 2026

Summary

Temporarily disables automatic publishing and website deployment workflows while keeping manual dispatch available.

Disabled automatic triggers

  • Nightly extension publishes on pushes to main
  • Production website deploys on main changes under apps/web-roo-code/**
  • Website preview deploys for PRs and non-main branches touching apps/web-roo-code/**

Still available

  • Manual runs via workflow_dispatch remain enabled for all three workflows.

Validation

  • pnpm lint
  • pnpm check-types

Summary by CodeRabbit

  • Chores
    • Disabled automatic deployment triggers for nightly builds, production, and preview environments. All deployments now require manual initiation instead of running automatically on code changes.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 25, 2026

📝 Walkthrough

Walkthrough

Three GitHub Actions workflow files had their automatic push/pull_request triggers disabled (commented out) and now run only via manual workflow_dispatch; job steps and deployment/publish logic are unchanged.

Changes

Cohort / File(s) Summary
GitHub Actions workflows
​.github/workflows/nightly-publish.yml, ​.github/workflows/website-deploy.yml, ​.github/workflows/website-preview.yml
Disabled automatic triggers by removing/commenting out push and pull_request event configurations; retained workflow_dispatch for manual runs. No job steps, build, deploy, or publish commands were altered. Minor YAML formatting/indentation adjustments included.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Nightly and site, I hush your tread,

Manual dispatch now wakes you instead.
Triggers tucked in soft, commented beds,
Jobs wait calmly — no more push-led.
A rabbit nods, and hops to bed. 🥕✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes a clear summary of changes and validation steps, but is missing critical required sections: it lacks a linked GitHub Issue (required per template), test procedure details, pre-submission checklist completion, and a Discord username for contact. Add 'Closes: #' to link the approved GitHub Issue, provide detailed test procedure steps, complete the pre-submission checklist, and include a Discord username for reviewer contact.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: disabling automatic deploy workflows. It is specific, clear, and directly matches the primary objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/disable-workflows

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
.github/workflows/nightly-publish.yml (1)

47-51: Make VSIX selection deterministic before publishing.

Using ls | head -n1 is order-dependent and can publish the wrong artifact if multiple files are present in bin/.

Proposed refactor
+            - name: Resolve nightly VSIX artifact
+              id: artifact
+              run: |
+                  VSIX_PATH=$(ls -1 bin/roo-code-nightly-*.vsix 2>/dev/null | head -n1)
+                  [ -n "$VSIX_PATH" ] || { echo "No nightly VSIX artifact found"; exit 1; }
+                  echo "path=$VSIX_PATH" >> "$GITHUB_OUTPUT"
             - name: Publish to VS Code Marketplace
               env:
                   VSCE_PAT: ${{ secrets.VSCE_PAT }}
-              run: npx vsce publish --packagePath "bin/$(/bin/ls bin | head -n1)"
+              run: npx vsce publish --packagePath "${{ steps.artifact.outputs.path }}"
             - name: Publish to Open VSX Registry
               env:
                   OVSX_PAT: ${{ secrets.OVSX_PAT }}
-              run: npx ovsx publish "bin/$(ls bin | head -n1)"
+              run: npx ovsx publish "${{ steps.artifact.outputs.path }}"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/nightly-publish.yml around lines 47 - 51, Replace the
unstable "ls | head -n1" selection in the two publish run steps with a
deterministic VSIX picker: locate VSIX files using a glob (e.g., bin/*.vsix),
sort them deterministically (e.g., sort -V) and pick the desired one (first or
last) so the same artifact is chosen each run; specifically update the two
commands that reference "bin/$(/bin/ls bin | head -n1)" and "bin/$(ls bin | head
-n1)" to something like bin/$(ls bin/*.vsix | sort -V | head -n1) (or tail -n1
to choose the highest version) so the chosen file is deterministic.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/nightly-publish.yml:
- Around line 3-5: The workflow currently uses a bare workflow_dispatch which
allows manual runs from any ref; restrict manual publishes to main by adding a
branches filter under workflow_dispatch (i.e., change the existing
workflow_dispatch to include branches: [main]) so only the main branch can
trigger the manual publish; apply the same change for the other
workflow_dispatch occurrence referenced (lines 8-9) so both manual dispatch
points are limited to main.

In @.github/workflows/website-deploy.yml:
- Around line 4-5: Add a branch guard so manual dispatches only run against
main: update the workflow_dispatch usage to still allow manual runs but add an
explicit conditional on the deployment job(s) (e.g., the job that performs the
production deploy) such as if: github.ref == 'refs/heads/main' so the job(s)
will early-skip when the workflow is dispatched against a non-main ref; keep
workflow_dispatch but add that job-level if guard to the deployment job(s).

---

Nitpick comments:
In @.github/workflows/nightly-publish.yml:
- Around line 47-51: Replace the unstable "ls | head -n1" selection in the two
publish run steps with a deterministic VSIX picker: locate VSIX files using a
glob (e.g., bin/*.vsix), sort them deterministically (e.g., sort -V) and pick
the desired one (first or last) so the same artifact is chosen each run;
specifically update the two commands that reference "bin/$(/bin/ls bin | head
-n1)" and "bin/$(ls bin | head -n1)" to something like bin/$(ls bin/*.vsix |
sort -V | head -n1) (or tail -n1 to choose the highest version) so the chosen
file is deterministic.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 822fc6fe-c07c-43e9-955b-3a6c145bc7a7

📥 Commits

Reviewing files that changed from the base of the PR and between 96d6e43 and d5bdcb0.

📒 Files selected for processing (3)
  • .github/workflows/nightly-publish.yml
  • .github/workflows/website-deploy.yml
  • .github/workflows/website-preview.yml

Comment thread .github/workflows/nightly-publish.yml Outdated
Comment on lines +4 to 5
# Temporarily disabled automatic production website deploys.
workflow_dispatch:
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Add a main-branch guard for manual production deploys.

After removing automatic push constraints, this workflow can be dispatched from non-main refs unless explicitly blocked.

Proposed fix
-        if: ${{ needs.check-secrets.outputs.has-vercel-token == 'true' }}
+        if: ${{ needs.check-secrets.outputs.has-vercel-token == 'true' && github.ref == 'refs/heads/main' }}

Also applies to: 33-33

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/website-deploy.yml around lines 4 - 5, Add a branch guard
so manual dispatches only run against main: update the workflow_dispatch usage
to still allow manual runs but add an explicit conditional on the deployment
job(s) (e.g., the job that performs the production deploy) such as if:
github.ref == 'refs/heads/main' so the job(s) will early-skip when the workflow
is dispatched against a non-main ref; keep workflow_dispatch but add that
job-level if guard to the deployment job(s).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is intentional

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only users with a collaborator, contributor, member, or owner role can interact with CodeRabbit.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/website-preview.yml (1)

4-12: Add explicit re-enable tracking for this temporary disable.

Since this is marked “temporarily disabled,” add an issue/owner/date reference in the comment so it doesn’t get forgotten.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/website-preview.yml around lines 4 - 12, Update the
existing comment that reads "Temporarily disabled automatic preview website
deploys." to include explicit re-enable tracking metadata: add an issue or
ticket reference number, an owner (GitHub handle), the date it was disabled, and
a target review/re-enable date or cadence so it won't be forgotten; ensure this
metadata sits directly above the commented-out push/pull_request block and is
clear (e.g., "TEMP_DISABLE: issue `#1234`, owner `@username`, disabled YYYY-MM-DD,
review YYYY-MM-DD").
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/website-preview.yml:
- Around line 4-12: Update the existing comment that reads "Temporarily disabled
automatic preview website deploys." to include explicit re-enable tracking
metadata: add an issue or ticket reference number, an owner (GitHub handle), the
date it was disabled, and a target review/re-enable date or cadence so it won't
be forgotten; ensure this metadata sits directly above the commented-out
push/pull_request block and is clear (e.g., "TEMP_DISABLE: issue `#1234`, owner
`@username`, disabled YYYY-MM-DD, review YYYY-MM-DD").

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fce82916-6182-4cf0-ad69-1979ca8e3c06

📥 Commits

Reviewing files that changed from the base of the PR and between d5bdcb0 and d2a7522.

📒 Files selected for processing (3)
  • .github/workflows/nightly-publish.yml
  • .github/workflows/website-deploy.yml
  • .github/workflows/website-preview.yml
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/nightly-publish.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/website-deploy.yml

Copy link
Copy Markdown

@edelauna edelauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment on lines +4 to 5
# Temporarily disabled automatic production website deploys.
workflow_dispatch:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is intentional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants