Prevent empty notifications when prepare fails.#11583
Prevent empty notifications when prepare fails.#11583desrosj wants to merge 3 commits intoWordPress:trunkfrom
prepare fails.#11583Conversation
Because of the `failure()` check, the `failure` job runs even when the message's payload is not properly prepared. This adds an additional check to guard against scenarios where the `payload` output is empty.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Pull request overview
Updates the reusable Slack notification workflow to avoid posting empty Slack notifications when the prepare job does not produce a payload output (e.g., when prepare fails).
Changes:
- Gate the
failurenotification job onneeds.prepare.outputs.payloadbeing non-empty. - Gate the
cancellednotification job onneeds.prepare.outputs.payloadbeing non-empty.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lue. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Because of the
failure()check, thefailurejob runs even when the message's payload is not properly prepared.This adds an additional check to guard against scenarios where the
payloadoutput is empty.This was discovered in this workflow run. The raw logs are being attached so that they persist after the 90 day retention period for logs passes.
Trac ticket: Core-64893.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude
Model(s): Opus 4.6
Used for: Investigating and creating the initial PR.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.