Fix clang-cl detection and add LIBPL_WARNINGS_AS_ERRORS#233
Open
mrexodia wants to merge 3 commits intoWerWolv:masterfrom
Open
Fix clang-cl detection and add LIBPL_WARNINGS_AS_ERRORS#233mrexodia wants to merge 3 commits intoWerWolv:masterfrom
mrexodia wants to merge 3 commits intoWerWolv:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
clang-cltheCMAKE_CXX_COMPILER_ID=Clangso this would set-Wallwhich enables all the warnings (unlike clang). This triggered a bunch of warnings related to c++98 compatibility which would then turn into an error.Additionally I made
LIBPL_WARNINGS_AS_ERRORSdefault toOFFwhen the project is used through FetchContent/add_subdirectory, because compiling with warnings as errors is generally bad practice there (newer compilers can introduce new warnings which then error out your main project for no reason).Also downgraded the standard requirement to C++20 as discussed on Discord.
(The actual 'proper' way to enable this is using
CMAKE_COMPILE_WARNING_AS_ERRORand a preset, but that's not relevant for now).