fix: add subscriptionLimits to Call response object#3
Closed
Conversation
Author
|
Closing this PR — the SDK is auto-generated by Fern. The correct fix is to update the OpenAPI spec in VapiAI/docs instead. Reopening as a fix to the source spec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubscriptionLimitsproperty to theCallrecord so the .NET SDK surfaces thesubscriptionLimitsblock returned by the REST API on individual call responses (e.g.POST /call,GET /call/{id})SubscriptionLimitstype already existed in the SDK (used byCallBatchResponse) but was missing from theCallmodel, causing customers to lose access to concurrency limit data when using the SDKProblem
When using the Vapi REST API directly, the CreateCall response includes:
{ "subscriptionLimits": { "concurrencyBlocked": false, "concurrencyLimit": 500, "remainingConcurrentCalls": 499 } }But the .NET SDK's
Callclass did not have aSubscriptionLimitsproperty, so this data was silently dropped during deserialization.Changes
src/Vapi.Net/Types/Call.cs-- AddedSubscriptionLimits? SubscriptionLimitsproperty with[JsonPropertyName("subscriptionLimits")]attribute, following the exact same pattern asCallBatchResponse.cssrc/Vapi.Net.Test/Core/Json/CallSubscriptionLimitsTests.cs-- 4 new tests:Test Plan
dotnet buildsucceeds with 0 errors across all target frameworks (net462, net8.0, net9.0, netstandard2.0)subscriptionLimitsdeserialize correctly (property is nullable)References