Skip to content

Fix router framework install links#866

Open
MoonBrillante wants to merge 1 commit intoTanStack:mainfrom
MoonBrillante:fix-install-instructions-link
Open

Fix router framework install links#866
MoonBrillante wants to merge 1 commit intoTanStack:mainfrom
MoonBrillante:fix-install-instructions-link

Conversation

@MoonBrillante
Copy link
Copy Markdown
Contributor

@MoonBrillante MoonBrillante commented Apr 27, 2026

Fixes #859

This PR adds the Router framework install path so the React and Solid "Full install instructions" links point to the quick-start pages instead of the broken installation page.

Summary by CodeRabbit

  • Updates
    • Updated quick-start documentation routing configuration to support framework-specific installation guides with standardized path templates.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 27, 2026

👷 Deploy request for tanstack pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5e2f3ee

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 10bb155e-b018-4028-93a0-5abce3f0b43a

📥 Commits

Reviewing files that changed from the base of the PR and between c937585 and 5e2f3ee.

📒 Files selected for processing (1)
  • src/libraries/libraries.ts

📝 Walkthrough

Walkthrough

Adds an installPath property to the TanStack Router library configuration, specifying a framework-parameterized quick-start documentation route template to correct broken installation instruction links.

Changes

Cohort / File(s) Summary
Router Library Configuration
src/libraries/libraries.ts
Adds installPath: 'framework/$framework/quick-start' to the router LibrarySlim object to fix broken documentation links for framework-specific installation instructions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A path was broken, links gone astray,
But now the router knows the way,
Through frameworks bright with $framework in tow,
Quick-start instructions steal the show! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix router framework install links' accurately summarizes the main change—adding an installPath field to fix broken framework installation links.
Linked Issues check ✅ Passed The code change directly addresses issue #859 by adding the installPath field to route broken links to the quick-start pages as required.
Out of Scope Changes check ✅ Passed The change is narrowly scoped and directly related to fixing the broken install links described in the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Full install instructions" link broken

1 participant