fix(LandingCodeExampleCard): prevent horizontal overflow on mobile#861
Merged
LadyBluenotes merged 1 commit intoTanStack:mainfrom Apr 26, 2026
Merged
Conversation
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
LadyBluenotes
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wrap
Tabs(withCodeBlockchildren) in amax-w-full min-w-0container so the landing code example stays within the parent width on mobile, allowing the inneroverflow-x-autoto take effect.Why
In the parent
flex flex-col items-centerlayout, flex items default tomin-width: auto, soTabsandCodeBlockexpanded to their natural content width (~496px) and overflowed past the mobile viewport (375px). The last tab (angular) was clipped and content appeared to overflow horizontally.Behavior
TabsandCodeBlockare constrained to the parent width and scroll horizontally within their own containers (no page-level horizontal scroll)Screenshot
AS-IS
TO-BE